Fill target errors with nans for evaluate #41919
Open
+605
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pyrit and not remove the other one
github-actions
bot
added
the
Evaluation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the target application step by filling any rows that fail execution with NaN values and logging a warning when such failures occur.
- Adds a warning log when some target executions fail.
- Reindexes the output to align with all input rows, filling missing ones with NaN.
- Adjusts the concatenation order to ensure equal-length DataFrames.
Comments suppressed due to low confidence (2)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_evaluate.py:620
- The function's docstring should be updated to mention that rows failing target execution are reindexed and filled with NaN, and that a warning is logged when failures occur.
if failed_lines > 0:
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_evaluate.py:638
- No unit test currently covers the scenario where some rows fail and are filled with NaN. Consider adding a test that simulates partial failures, asserts NaN in the missing rows, and verifies the warning is logged.
target_output = target_output.reindex(complete_index)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines